Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split submission_services_summary allow_list_answers into their own columns in view #2927

Merged

Conversation

Mike-Heneghan
Copy link
Contributor

What

  • Split the submission_services_summary allow_list_answers into separate columns

Why

  • Allow Metabase seems to be unfolding some of the ALLOW_LIST answers it's not covering everything
  • Splitting the allow_list_answers means we don't have to rely on the flakey unfolding

@Mike-Heneghan Mike-Heneghan requested review from zz-hh-aa and a team March 26, 2024 17:23
@Mike-Heneghan Mike-Heneghan self-assigned this Mar 26, 2024
(ls.submitted_at::date - ls.created_at::date) as session_length_days,
ls.has_user_saved as user_clicked_save,
rps.number_times_resumed,
ls.allow_list_answers,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mike-Heneghan Mike-Heneghan force-pushed the mh/submission-services-summary-split-allow-list-answers branch from e7a7694 to a2971ae Compare March 26, 2024 17:31
Copy link

github-actions bot commented Mar 26, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@Mike-Heneghan Mike-Heneghan merged commit 5876082 into main Mar 27, 2024
12 checks passed
@Mike-Heneghan
Copy link
Contributor Author

@Mike-Heneghan Mike-Heneghan deleted the mh/submission-services-summary-split-allow-list-answers branch April 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants